I think what you have would work, I don't know if it is optimal. For example, with the herbie I don't think you will need a bubble trap off the drain since you shouldn't be getting bubbles there. Not knowing what all your equipment is, it does look like it could be simplified. You seem you be using your eheim to run a skimmer and uv? You could scrap the cannister and t off the return to run uv and/or reactors (I assume the skimmer actually has its own pump
).
As for the herbie specifically, looks like you have it right. Your 2 drains are not tied together, you have the siphon lower than the emergency, and you have the drains terminating a couple inches below the water in the sump. Looks good!
- ian